◐ Shell
clean mode source ↗

Fix MSVC cross compilation by Faless · Pull Request #7079 · libgit2/libgit2

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

Currently, the DefaultCFlags.cmake overrides the
CMAKE_STATIC_LINKER_FLAGS to suppress linker warnings about files with
no symbols defined.

This has the side effect of breaking MSVC cross compilation (where
CMAKE_STATIC_LINKER_FLAGS is used to specify the /MACHINE:ARCH flag)

This commit make sure we append to CMAKE_STATIC_LINKER_FLAGS instead of
replacing its values

ethomson

@Faless Faless deleted the fix/static_linker_flags branch

June 4, 2025 10:21

Labels