Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method by svegaxmr · Pull Request #100 · lmdbjava/lmdbjava
Conversation
svegaxmr
commented
Jul 24, 2018
svegaxmr
commented
Contributor
necessary for code like mdb_cursor_get(m_cur_block_heights, (MDB_val *)&zerokval, &val_h, MDB_GET_BOTH)
bp-alex
commented
Dec 7, 2018
bp-alex commented
Member
Thanks for this PR. Would you mind please providing a corresponding test case?
bp-alex
removed
the
awaiting response
label
svegaxmr
commented
Jan 17, 2019
svegaxmr commented
Contributor Author
What is the highest version of Java that the tests can target?
Codecov Report
Merging #100 into master will increase coverage by
0.05%.
The diff coverage is0%.
@@ Coverage Diff @@ ## master #100 +/- ## ============================================ + Coverage 90.98% 91.04% +0.05% + Complexity 373 352 -21 ============================================ Files 29 28 -1 Lines 1265 1172 -93 Branches 113 106 -7 ============================================ - Hits 1151 1067 -84 + Misses 48 45 -3 + Partials 66 60 -6
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| src/main/java/org/lmdbjava/Cursor.java | 80% <0%> (-10%) |
25 <0> (ø) |
|
| src/main/java/org/lmdbjava/Verifier.java |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update a927565...7a70355. Read the comment docs.
bp-alex
force-pushed
the
master
branch
11 times, most recently
from
8809f8e to
fed0c5d
Compare
bp-alex
merged commit
e5f5008
into
lmdbjava:master
bp-alex
changed the title
add cursor seek for MDB_GET_BOTH
Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method
bp-alex
commented
Apr 15, 2020
bp-alex commented
Member
Thanks for the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment