◐ Shell
clean mode source ↗

Support User Defined PooledByteBufAllocator by Maithem · Pull Request #162 · lmdbjava/lmdbjava

@Maithem

@Maithem Maithem commented

Aug 18, 2020

Copy link Copy Markdown

Contributor

This patch allows users to pass a PooledByteBufAllocator instance
if they wish to not use the DEFAULT instance. Also, this patch
fixes a minor bug where a ByteBuf is created during initialization
without ever being released.

This patch allows users to pass a PooledByteBufAllocator instance
if they wish to not use the DEFAULT instance. Also, this patch
fixes a minor bug where a ByteBuf is created during initialization
without ever being released.

@codecov-commenter

Copy link Copy Markdown

Codecov Report

Merging #162 into master will increase coverage by 0.12%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #162      +/-   ##
============================================
+ Coverage     90.93%   91.06%   +0.12%     
+ Complexity      383      382       -1     
============================================
  Files            30       30              
  Lines          1346     1343       -3     
  Branches        118      116       -2     
============================================
- Hits           1224     1223       -1     
  Misses           58       58              
+ Partials         64       62       -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/lmdbjava/ByteBufProxy.java 81.13% <92.30%> (+2.56%) 11.00 <3.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d76be...cb19f59. Read the comment docs.

@bp-alex bp-alex merged commit 3a0a702 into lmdbjava:master

Oct 24, 2020

@bp-alex

bp-alex commented

Oct 24, 2020

Copy link Copy Markdown

Member

Thank you @Maithem.

@Maithem Maithem deleted the pooledAllocator branch

January 20, 2021 00:37