Widen the stdio round-trip test's termination grace and overall timeout by maxisbey · Pull Request #2880 · modelcontextprotocol/python-sdk
The test patches PROCESS_TERMINATION_TIMEOUT so the spawned server can unwind, save its subprocess coverage data, and print the clean-exit line before the kill escalation. One heavily starved Windows CI runner stalled the child past the previous 10s grace, so it was killed before printing and the stderr assertion failed with empty output. The post-stdin-close tail is normally well under a second even on loaded Windows runners, so double the grace to 20s (and the outer fail_after to 30s); the grace wait returns as soon as the child exits, so passing runs are unaffected.
marked this pull request as ready for review
maxisbey
deleted the
maxisbey/stdio-roundtrip-teardown-grace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters