Add module name to the package manifest attributes by thatcomputerguy0101 · Pull Request #986 · msgpack/msgpack-java
-
Notifications
You must be signed in to change notification settings - Fork 323
Conversation
I tried pulling msgpack-core in through Maven, and I noticed that the module name was being parsed from the jar file name as msgpack.core instead of org.msgpack.core. This change adds the module name defined in the sbt config to the package manifest attributes so that Maven autodetects the correct name.
(PS: I'm not very familiar with sbt, so there may be a better way to do this.)
Actually, I failed to test my final revision of this properly, so this doesn't work right now. I think it is fixed now.
`-` is not a vaild character for module names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 participant
