Reuse Encoder/Decoder instance by buu700 · Pull Request #177 · msgpack/msgpack-javascript

buu700

Copy link

Copy Markdown

Addresses #172

buu700 force-pushed the encoder-instance-reuse branch from d338d94 to 381f7e0 Compare

Copy link

Copy Markdown

Member

Thank you for the contribution. We need to make sure it's safe when we use this PR in the async/await context.

Copy link

Copy Markdown

Member

Ah, right. It only changes the synchronous functions, although CI failed. It looks good.

Could you take a look at CI failure? I'll merge this PR if CI passes.

msgpack#172

buu700 force-pushed the encoder-instance-reuse branch from 381f7e0 to 252ea39 Compare

Copy link

Copy Markdown

Author

Cool, sounds good. I'll investigate the failure as soon as I have a moment, but just rebased on the tip of main in case that makes a difference.