Upgrade libgit2 to 1.3.1 by zawata · Pull Request #1894 · nodegit/nodegit

Several changes were made:

• commit signing callback was deprecated in favor of a commit creation callback
  • callback returns an OID through a pointer to an oid struct. not sure if this could be handled better, looking for suggestions
  • contains a list parameter that required some modification to accommodate
• public git_buf modification functions were deprecated as modifying git_buffers are now considered internal only
  • the only place this affects us is in the git_filter apply callback function which has also been deprecated but will be modified in another PR since it requires bigger changes
• adjusted arrayType regex to accommodate array parameters
• removed win32 long-paths since it's included in libgit2 config handling
• fix compilation of new ntlmclient version

Note: A majority of the PR changes are the new Libgit2-docs.json

In the meantime libgit 1.4.2 is out, would that be an easy upgrade?

@wmertens when I started this 1.4 had just come out and we decided to make changes incrememental rather than large(r) version jumps to help with API stabilization and minimize implementation problems. I do have the 1.4 upgrade in my backlog but I think theres some higher priority tasks to get done first(at least from my end) like filter streaming.

The actual upgrade to 1.4 doesn't look super complex but i wouldn't no for certain until I start working on it.

In light of the recent libgit2 security release, I'll update this PR to use libgit 1.3.1. Luckily this won't require any code or libgit2-docs changes. I've already confirmed it builds.

@ianhattendorf I've updated my fork of the libgit-next branch. Please push it when convenient and I'll update the submodule in this PR. https://github.com/zawata/libgit2/tree/libgit-next

PR updated to libgit2 v1.3.1