Fix memory leaks by julianmesa-gitkraken · Pull Request #1944 · nodegit/nodegit
-
Notifications
You must be signed in to change notification settings - Fork 700
Open
wants to merge 18 commits into
Open
Fix memory leaks#1944
wants to merge 18 commits into
Fix memory leaks#1944
wants to merge 18 commits into
Conversation
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
2 times, most recently
from
4fcce07 to
a24d5f8
Compare
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
a24d5f8 to
77cdd5c
Compare
julianmesa-gitkraken added 2 commits
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
8ca3108 to
2900bf1
Compare
We need to free duplicated memory we are responsible for that we obtained from libgit2 because nodegit duplicates it again when calling the wrapper
julianmesa-gitkraken
changed the title
Fix memory leaks
[WIP] Fix memory leaks
julianmesa-gitkraken
marked this pull request as draft
julianmesa-gitkraken added 2 commits
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
be79188 to
9eb357e
Compare
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
b2b40bc to
e381446
Compare
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
e381446 to
c8afbe6
Compare
julianmesa-gitkraken added 4 commits
We only free baton on some cases, but we should try to free all previously allocated memory.
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
3ffe4db to
7b5c85b
Compare
julianmesa-gitkraken added 4 commits
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
c7e48b8 to
c682630
Compare
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
c682630 to
d4981f0
Compare
julianmesa-gitkraken
changed the title
[WIP] Fix memory leaks
Fix memory leaks
julianmesa-gitkraken
marked this pull request as ready for review
julianmesa-gitkraken
force-pushed
the
fix-memory-leaks
branch
from
5551f94 to
842196f
Compare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment