◐ Shell
clean mode source ↗

sqlite: aggregate constants in a single property · nodejs/node@0ab36e1

@@ -3,9 +3,7 @@

33

require('../common');

44

const {

55

DatabaseSync,

6-

SQLITE_CHANGESET_OMIT,

7-

SQLITE_CHANGESET_REPLACE,

8-

SQLITE_CHANGESET_ABORT

6+

constants,

97

} = require('node:sqlite');

108

const { test, suite } = require('node:test');

119

@@ -165,7 +163,7 @@ suite('conflict resolution', () => {

165163

test('database.applyChangeset() - conflict with SQLITE_CHANGESET_ABORT', (t) => {

166164

const { database2, changeset } = prepareConflict();

167165

const result = database2.applyChangeset(changeset, {

168-

onConflict: SQLITE_CHANGESET_ABORT

166+

onConflict: constants.SQLITE_CHANGESET_ABORT

169167

});

170168

// When changeset is aborted due to a conflict, applyChangeset should return false

171169

t.assert.strictEqual(result, false);

@@ -177,7 +175,7 @@ suite('conflict resolution', () => {

177175

test('database.applyChangeset() - conflict with SQLITE_CHANGESET_REPLACE', (t) => {

178176

const { database2, changeset } = prepareConflict();

179177

const result = database2.applyChangeset(changeset, {

180-

onConflict: SQLITE_CHANGESET_REPLACE

178+

onConflict: constants.SQLITE_CHANGESET_REPLACE

181179

});

182180

// Not aborted due to conflict, so should return true

183181

t.assert.strictEqual(result, true);

@@ -189,7 +187,7 @@ suite('conflict resolution', () => {

189187

test('database.applyChangeset() - conflict with SQLITE_CHANGESET_OMIT', (t) => {

190188

const { database2, changeset } = prepareConflict();

191189

const result = database2.applyChangeset(changeset, {

192-

onConflict: SQLITE_CHANGESET_OMIT

190+

onConflict: constants.SQLITE_CHANGESET_OMIT

193191

});

194192

// Not aborted due to conflict, so should return true

195193

t.assert.strictEqual(result, true);

@@ -199,12 +197,6 @@ suite('conflict resolution', () => {

199197

});

200198

});

201199202-

test('session related constants are defined', (t) => {

203-

t.assert.strictEqual(SQLITE_CHANGESET_OMIT, 0);

204-

t.assert.strictEqual(SQLITE_CHANGESET_REPLACE, 1);

205-

t.assert.strictEqual(SQLITE_CHANGESET_ABORT, 2);

206-

});

207-208200

test('database.createSession() - filter changes', (t) => {

209201

const database1 = new DatabaseSync(':memory:');

210202

const database2 = new DatabaseSync(':memory:');