util: fix Latin1 decoding to return string output · nodejs/node@1381541

env->isolate(), "The encoded data was not valid for encoding latin1");

}

Local<Object> buffer_result =

node::Buffer::Copy(env, result.c_str(), written).ToLocalChecked();

args.GetReturnValue().Set(buffer_result);

Local<String> output =

String::NewFromUtf8(

env->isolate(), result.c_str(), v8::NewStringType::kNormal, written)

.ToLocalChecked();

args.GetReturnValue().Set(output);

}

} // namespace encoding_binding

return false;

}

*result = try_catch.Exception();

*result = args[0];

return true;

}

EXPECT_STREQ(*utf8_result, "Áéó");

}

TEST_F(EncodingBindingTest, DecodeLatin1_ReturnsString) {

Environment* env = CreateEnvironment();

Isolate* isolate = env->isolate();

HandleScope handle_scope(isolate);

const uint8_t latin1_data[] = {0xC1, 0xE9, 0xF3};

Local<ArrayBuffer> ab = ArrayBuffer::New(isolate, sizeof(latin1_data));

memcpy(ab->GetBackingStore()->Data(), latin1_data, sizeof(latin1_data));

Local<Uint8Array> array = Uint8Array::New(ab, 0, sizeof(latin1_data));

Local<Value> args[] = {array};

Local<Value> result;

ASSERT_TRUE(RunDecodeLatin1(env, args, false, false, &result));

ASSERT_TRUE(result->IsString());

String::Utf8Value utf8_result(isolate, result);

EXPECT_STREQ(*utf8_result, "Áéó");

}

} // namespace encoding_binding

} // namespace node

'use strict';

const common = require('../common');

const test = require('node:test');

const assert = require('node:assert');

test('TextDecoder correctly decodes windows-1252 encoded data', { skip: !common.hasIntl }, () => {

const latin1Bytes = new Uint8Array([0xc1, 0xe9, 0xf3]);

const expectedString = 'Áéó';

const decoder = new TextDecoder('windows-1252');

const decodedString = decoder.decode(latin1Bytes);

assert.strictEqual(decodedString, expectedString);

});