src: fix kill signal on Windows · nodejs/node@2ca9f4b

See kill(2) for reference.

On Windows, where POSIX signals do not exist, the `signal` argument will be

ignored, and the process will be killed forcefully and abruptly (similar to

`'SIGKILL'`).

ignored except for `'SIGKILL'`, `'SIGTERM'`, `'SIGINT'` and `'SIGQUIT'`, and the

process will always be killed forcefully and abruptly (similar to `'SIGKILL'`).

See [Signal Events][] for more details.

On Linux, child processes of child processes will not be terminated

ProcessWrap* wrap;

ASSIGN_OR_RETURN_UNWRAP(&wrap, args.This());

int signal = args[0]->Int32Value(env->context()).FromJust();

#ifdef _WIN32

if (signal != SIGKILL && signal != SIGTERM && signal != SIGINT &&

signal != SIGQUIT) {

signal = SIGKILL;

}

#endif

int err = uv_process_kill(&wrap->process_, signal);

args.GetReturnValue().Set(err);

}

assert.strictEqual(cat.killed, false);

cat.kill();

assert.strictEqual(cat.killed, true);

// Test different types of kill signals on Windows.

if (common.isWindows) {

for (const sendSignal of ['SIGTERM', 'SIGKILL', 'SIGQUIT', 'SIGINT']) {

const process = spawn('cmd');

process.on('exit', (code, signal) => {

assert.strictEqual(code, null);

assert.strictEqual(signal, sendSignal);

});

process.kill(sendSignal);

}

const process = spawn('cmd');

process.on('exit', (code, signal) => {

assert.strictEqual(code, null);

assert.strictEqual(signal, 'SIGKILL');

});

process.kill('SIGHUP');

}