module: cache synchronous module jobs before linking · nodejs/node@30ed93d

#loader = null;

constructor(loader, url, importAttributes, moduleWrap, isMain, inspectBrk) {

super(url, importAttributes, moduleWrap, isMain, inspectBrk, true);

assert(this.module instanceof ModuleWrap);

this.#loader = loader;

const moduleRequests = this.module.getModuleRequests();

// Specifiers should be aligned with the moduleRequests array in order.

const specifiers = Array(moduleRequests.length);

const modules = Array(moduleRequests.length);

const jobs = Array(moduleRequests.length);

for (let i = 0; i < moduleRequests.length; ++i) {

const { specifier, attributes } = moduleRequests[i];

const job = this.#loader.getModuleJobForRequire(specifier, url, attributes);

specifiers[i] = specifier;

modules[i] = job.module;

jobs[i] = job;

assert(this.module instanceof ModuleWrap);

// Store itself into the cache first before linking in case there are circular

// references in the linking.

loader.loadCache.set(url, importAttributes.type, this);

try {

const moduleRequests = this.module.getModuleRequests();

// Specifiers should be aligned with the moduleRequests array in order.

const specifiers = Array(moduleRequests.length);

const modules = Array(moduleRequests.length);

const jobs = Array(moduleRequests.length);

for (let i = 0; i < moduleRequests.length; ++i) {

const { specifier, attributes } = moduleRequests[i];

const job = this.#loader.getModuleJobForRequire(specifier, url, attributes);

specifiers[i] = specifier;

modules[i] = job.module;

jobs[i] = job;

}

this.module.link(specifiers, modules);

this.linked = jobs;

} finally {

// Restore it - if it succeeds, we'll reset in the caller; Otherwise it's

// not cached and if the error is caught, subsequent attempt would still fail.

loader.loadCache.delete(url, importAttributes.type);

}

this.module.link(specifiers, modules);

this.linked = jobs;

}

get modulePromise() {