◐ Shell
clean mode source ↗

stream: fix writev unhandled rejection in fromWeb · nodejs/node@3ed7835

Original file line numberDiff line numberDiff line change

@@ -313,9 +313,8 @@ function newStreamWritableFromWritableStream(writableStream, options = kEmptyObj

313313
314314

writev(chunks, callback) {

315315

function done(error) {

316-

error = error.filter((e) => e);

317316

try {

318-

callback(error.length === 0 ? undefined : error);

317+

callback(error);

319318

} catch (error) {

320319

// In a next tick because this is happening within

321320

// a promise context, and if there are any errors

@@ -333,7 +332,7 @@ function newStreamWritableFromWritableStream(writableStream, options = kEmptyObj

333332

SafePromiseAll(

334333

chunks,

335334

(data) => writer.write(data.chunk)),

336-

done,

335+

() => done(),

337336

done);

338337

},

339338

done);

@@ -775,9 +774,8 @@ function newStreamDuplexFromReadableWritablePair(pair = kEmptyObject, options =

775774
776775

writev(chunks, callback) {

777776

function done(error) {

778-

error = error.filter((e) => e);

779777

try {

780-

callback(error.length === 0 ? undefined : error);

778+

callback(error);

781779

} catch (error) {

782780

// In a next tick because this is happening within

783781

// a promise context, and if there are any errors

@@ -795,7 +793,7 @@ function newStreamDuplexFromReadableWritablePair(pair = kEmptyObject, options =

795793

SafePromiseAll(

796794

chunks,

797795

(data) => writer.write(data.chunk)),

798-

done,

796+

() => done(),

799797

done);

800798

},

801799

done);