◐ Shell
clean mode source ↗

src: use cached `emit` v8::String · nodejs/node@7a554d9

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Commit 7a554d9

daeyeonaduh95

authored and

committed

src: use cached emit v8::String

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #57249 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

Lines changed: 2 additions & 1 deletion

Original file line numberDiff line numberDiff line change

@@ -56,7 +56,8 @@ MaybeLocal<Value> ProcessEmit(Environment* env,

5656
5757

Local<Object> process = env->process_object();

5858

Local<Value> argv[] = {event_string, message};

59-

return MakeCallback(isolate, process, "emit", arraysize(argv), argv, {0, 0});

59+

return MakeCallback(

60+

isolate, process, env->emit_string(), arraysize(argv), argv, {0, 0});

6061

}

6162
6263

Maybe<bool> ProcessEmitWarningGeneric(Environment* env,