◐ Shell
clean mode source ↗

test: update `startCLI` to set `--port=0` by default · nodejs/node@82d4175

Original file line numberDiff line numberDiff line change

@@ -20,10 +20,14 @@ function isPreBreak(output) {

2020

return /Break on start/.test(output) && /1 \(function \(exports/.test(output);

2121

}

2222
23-

function startCLI(args, flags = [], spawnOpts = {}) {

23+

function startCLI(args, flags = [], spawnOpts = {}, opts = { randomPort: true }) {

2424

let stderrOutput = '';

25-

const child =

26-

spawn(process.execPath, [...flags, 'inspect', ...args], spawnOpts);

25+

const child = spawn(process.execPath, [

26+

...flags,

27+

'inspect',

28+

...(opts.randomPort !== false ? ['--port=0'] : []),

29+

...args,

30+

], spawnOpts);

2731
2832

const outputBuffer = [];

2933

function bufferOutput(chunk) {

Original file line numberDiff line numberDiff line change

@@ -55,7 +55,7 @@ function launchTarget(...args) {

5555

try {

5656

const { childProc, host, port } = await launchTarget('--inspect=0', script);

5757

target = childProc;

58-

cli = startCLI([`${host || '127.0.0.1'}:${port}`]);

58+

cli = startCLI([`${host || '127.0.0.1'}:${port}`], [], {}, { randomPort: false });

5959

await cli.waitForPrompt();

6060

await cli.command('sb("alive.js", 3)');

6161

await cli.waitFor(/break/);

Original file line numberDiff line numberDiff line change

@@ -21,9 +21,7 @@ addLibraryPath(process.env);

2121

};

2222

env.NODE_INSPECT_RESUME_ON_START = '1';

2323
24-

const cli = startCLI(['--port=0', script], [], {

25-

env,

26-

});

24+

const cli = startCLI([script], [], { env });

2725
2826

await cli.waitForInitialBreak();

2927

deepStrictEqual(cli.breakInfo, {

Original file line numberDiff line numberDiff line change

@@ -13,7 +13,7 @@ const path = require('path');

1313

{

1414

const scriptFullPath = fixtures.path('debugger', 'backtrace.js');

1515

const script = path.relative(process.cwd(), scriptFullPath);

16-

const cli = startCLI(['--port=0', script]);

16+

const cli = startCLI([script]);

1717
1818

async function runTest() {

1919

try {

Original file line numberDiff line numberDiff line change

@@ -11,7 +11,7 @@ const path = require('path');

1111
1212

const scriptFullPath = fixtures.path('debugger', 'break.js');

1313

const script = path.relative(process.cwd(), scriptFullPath);

14-

const cli = startCLI(['--port=0', script]);

14+

const cli = startCLI([script]);

1515
1616

(async () => {

1717

await cli.waitForInitialBreak();

Original file line numberDiff line numberDiff line change

@@ -9,7 +9,7 @@ const startCLI = require('../common/debugger');

99
1010

// Test for "Breakpoint at specified location already exists" error.

1111

const script = fixtures.path('debugger', 'three-lines.js');

12-

const cli = startCLI(['--port=0', script]);

12+

const cli = startCLI([script]);

1313
1414

(async () => {

1515

try {

Original file line numberDiff line numberDiff line change

@@ -13,7 +13,7 @@ const path = require('path');

1313

{

1414

const scriptFullPath = fixtures.path('debugger', 'break.js');

1515

const script = path.relative(process.cwd(), scriptFullPath);

16-

const cli = startCLI(['--port=0', script]);

16+

const cli = startCLI([script]);

1717
1818

function onFatal(error) {

1919

cli.quit();

Original file line numberDiff line numberDiff line change

@@ -13,7 +13,7 @@ const path = require('path');

1313

{

1414

const scriptFullPath = fixtures.path('debugger', 'exceptions.js');

1515

const script = path.relative(process.cwd(), scriptFullPath);

16-

const cli = startCLI(['--port=0', script]);

16+

const cli = startCLI([script]);

1717
1818

(async () => {

1919

try {

Original file line numberDiff line numberDiff line change

@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';

77
88

import assert from 'assert';

99
10-

const cli = startCLI(['--port=0', path('debugger/backtrace.js')]);

10+

const cli = startCLI([path('debugger/backtrace.js')]);

1111
1212

try {

1313

await cli.waitForInitialBreak();

Original file line numberDiff line numberDiff line change

@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');

88
99

const assert = require('assert');

1010
11-

const cli = startCLI(['--port=0', fixtures.path('debugger/alive.js')]);

11+

const cli = startCLI([fixtures.path('debugger/alive.js')]);

1212
1313

async function waitInitialBreak() {

1414

try {