◐ Shell
clean mode source ↗

assert: optimize partial comparison of two `Set`s · nodejs/node@a4fa31a

@@ -414,33 +414,25 @@ function compareBranch(

414414

}

415415416416

// Check for Set object equality

417-

// TODO(aduh95): switch to `SetPrototypeIsSubsetOf` when it's available

418417

if (isSet(actual) && isSet(expected)) {

419418

if (expected.size > actual.size) {

420419

return false; // `expected` can't be a subset if it has more elements

421420

}

422421423422

if (isDeepEqual === undefined) lazyLoadComparison();

424423425-

const actualArray = ArrayFrom(actual);

426-

const expectedArray = ArrayFrom(expected);

424+

const actualArray = ArrayFrom(FunctionPrototypeCall(SafeSet.prototype[SymbolIterator], actual));

425+

const expectedIterator = FunctionPrototypeCall(SafeSet.prototype[SymbolIterator], expected);

427426

const usedIndices = new SafeSet();

428427429-

for (let expectedIdx = 0; expectedIdx < expectedArray.length; expectedIdx++) {

430-

const expectedItem = expectedArray[expectedIdx];

431-

let found = false;

432-428+

expectedIteration: for (const expectedItem of expectedIterator) {

433429

for (let actualIdx = 0; actualIdx < actualArray.length; actualIdx++) {

434430

if (!usedIndices.has(actualIdx) && isDeepStrictEqual(actualArray[actualIdx], expectedItem)) {

435431

usedIndices.add(actualIdx);

436-

found = true;

437-

break;

432+

continue expectedIteration;

438433

}

439434

}

440-441-

if (!found) {

442-

return false;

443-

}

435+

return false;

444436

}

445437446438

return true;