◐ Shell
clean mode source ↗

quic: fixup token verification to handle zero expiration · nodejs/node@c128942

@@ -208,7 +208,7 @@ void ngtcp2_debug_log(void* user_data, const char* fmt, ...) {

208208

va_end(ap);

209209

}

210210211-

template <typename Opt, PreferredAddress::Policy Opt::* member>

211+

template <typename Opt, PreferredAddress::Policy Opt::*member>

212212

bool SetOption(Environment* env,

213213

Opt* options,

214214

const Local<Object>& object,

@@ -223,7 +223,7 @@ bool SetOption(Environment* env,

223223

return true;

224224

}

225225226-

template <typename Opt, TLSContext::Options Opt::* member>

226+

template <typename Opt, TLSContext::Options Opt::*member>

227227

bool SetOption(Environment* env,

228228

Opt* options,

229229

const Local<Object>& object,

@@ -238,7 +238,7 @@ bool SetOption(Environment* env,

238238

return true;

239239

}

240240241-

template <typename Opt, TransportParams::Options Opt::* member>

241+

template <typename Opt, TransportParams::Options Opt::*member>

242242

bool SetOption(Environment* env,

243243

Opt* options,

244244

const Local<Object>& object,

@@ -253,7 +253,7 @@ bool SetOption(Environment* env,

253253

return true;

254254

}

255255256-

template <typename Opt, ngtcp2_cc_algo Opt::* member>

256+

template <typename Opt, ngtcp2_cc_algo Opt::*member>

257257

bool SetOption(Environment* env,

258258

Opt* options,

259259

const Local<Object>& object,

@@ -2480,7 +2480,9 @@ bool Session::HandshakeCompleted() {

2480248024812481

// If early data was attempted but rejected by the server,

24822482

// tell ngtcp2 so it can retransmit the data as 1-RTT.

2483-

if (!is_server() && !tls_session().early_data_was_accepted())

2483+

// The status of early data will only be rejected if an

2484+

// attempt was actually made to send early data.

2485+

if (!is_server() && tls_session().early_data_was_rejected())

24842486

ngtcp2_conn_tls_early_data_rejected(*this);

2485248724862488

// When in a server session, handshake completed == handshake confirmed.

@@ -2709,6 +2711,7 @@ void Session::EmitHandshakeComplete() {

27092711

Undefined(isolate), // Cipher version

27102712

Undefined(isolate), // Validation error reason

27112713

Undefined(isolate), // Validation error code

2714+

Boolean::New(isolate, tls_session().early_data_was_attempted()),

27122715

Boolean::New(isolate, tls_session().early_data_was_accepted())};

2713271627142717

auto& tls = tls_session();