worker: fix worker name with \0 · nodejs/node@c38b7cf

NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(

Environment* env, ThreadId thread_id, const char* url, const char* name) {

CHECK_NOT_NULL(env);

if (url == nullptr) url = "";

if (name == nullptr) name = "";

std::string_view url_view(url);

std::string_view name_view(name);

return GetInspectorParentHandle(env, thread_id, url_view, name_view);

}

NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(

Environment* env,

ThreadId thread_id,

std::string_view url,

std::string_view name) {

CHECK_NOT_NULL(env);

CHECK_NE(thread_id.id, static_cast<uint64_t>(-1));

if (!env->should_create_inspector()) {

return nullptr;

ParentInspectorHandle::ParentInspectorHandle(

uint64_t id,

const std::string& url,

std::string_view url,

std::shared_ptr<MainThreadHandle> parent_thread,

bool wait_for_connect,

const std::string& name,

std::string_view name,

std::shared_ptr<NetworkResourceManager> network_resource_manager)

: id_(id),

url_(url),

std::unique_ptr<ParentInspectorHandle> WorkerManager::NewParentHandle(

uint64_t thread_id,

const std::string& url,

const std::string& name,

std::string_view url,

std::string_view name,

std::shared_ptr<NetworkResourceManager> network_resource_manager) {

bool wait = !delegates_waiting_on_start_.empty();

return std::make_unique<ParentInspectorHandle>(

public:

ParentInspectorHandle(

uint64_t id,

const std::string& url,

std::string_view url,

std::shared_ptr<MainThreadHandle> parent_thread,

bool wait_for_connect,

const std::string& name,

std::string_view name,

std::shared_ptr<NetworkResourceManager> network_resource_manager);

~ParentInspectorHandle();

std::unique_ptr<ParentInspectorHandle> NewParentInspectorHandle(

uint64_t thread_id, const std::string& url, const std::string& name) {

uint64_t thread_id, std::string_view url, std::string_view name) {

return std::make_unique<ParentInspectorHandle>(

thread_id, url, parent_thread_, wait_, name, network_resource_manager_);

}

std::unique_ptr<ParentInspectorHandle> NewParentHandle(

uint64_t thread_id,

const std::string& url,

const std::string& name,

std::string_view url,

std::string_view name,

std::shared_ptr<NetworkResourceManager> network_resource_manager);

void WorkerStarted(uint64_t session_id, const WorkerInfo& info, bool waiting);

void WorkerFinished(uint64_t session_id);

}

std::unique_ptr<ParentInspectorHandle> Agent::GetParentHandle(

uint64_t thread_id, const std::string& url, const std::string& name) {

uint64_t thread_id, std::string_view url, std::string_view name) {

THROW_IF_INSUFFICIENT_PERMISSIONS(parent_env_,

permission::PermissionScope::kInspector,

"GetParentHandle",

void DisableAsyncHook();

void SetParentHandle(std::unique_ptr<ParentInspectorHandle> parent_handle);

std::unique_ptr<ParentInspectorHandle> GetParentHandle(

uint64_t thread_id, const std::string& url, const std::string& name);

std::unique_ptr<ParentInspectorHandle> GetParentHandle(uint64_t thread_id,

std::string_view url,

std::string_view name);

// Called to create inspector sessions that can be used from the same thread.

// The inspector responds by using the delegate to send messages back.

const char* child_url,

const char* name);

NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(

Environment* parent_env,

ThreadId child_thread_id,

std::string_view child_url,

std::string_view name);

struct StartExecutionCallbackInfo {

v8::Local<v8::Object> process_object;

v8::Local<v8::Function> native_require;

if (env->permission()->is_granted(

env, node::permission::PermissionScope::kInspector)) {

inspector_parent_handle_ =

GetInspectorParentHandle(env, thread_id_, url.c_str(), name.c_str());

GetInspectorParentHandle(env, thread_id_, url, name);

}

argv_ = std::vector<std::string>{env->argv()[0]};

const assert = require('assert');

if (isMainThread) {

const name = 'Hello Thread';

const name = 'Hello\0Thread';

const expectedTitle = `[worker 1] ${name}`;

const worker = new Worker(fixtures.path('worker-name.js'), {

name,