◐ Shell
clean mode source ↗

src: use context-free V8 message column getters · nodejs/node@c70ff44

Original file line numberDiff line numberDiff line change

@@ -652,7 +652,7 @@ class NodeInspectorClient : public V8InspectorClient {

652652

ToInspectorString(isolate, message->Get())->string(),

653653

ToInspectorString(isolate, message->GetScriptResourceName())->string(),

654654

message->GetLineNumber(context).FromMaybe(0),

655-

message->GetStartColumn(context).FromMaybe(0),

655+

message->GetStartColumn(),

656656

client_->createStackTrace(stack_trace),

657657

script_id);

658658

}

Original file line numberDiff line numberDiff line change

@@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate,

6565

// the source texts.

6666

Local<Value> script_resource_name = message->GetScriptResourceName();

6767

int linenum = message->GetLineNumber(context).FromJust();

68-

int columnum = message->GetStartColumn(context).FromJust();

68+

int columnum = message->GetStartColumn();

6969
7070

Local<Value> argv[] = {script_resource_name,

7171

v8::Int32::New(isolate, linenum),

@@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate,

148148

int script_start = (linenum - origin.LineOffset()) == 1

149149

? origin.ColumnOffset()

150150

: 0;

151-

int start = message->GetStartColumn(context).FromMaybe(0);

152-

int end = message->GetEndColumn(context).FromMaybe(0);

151+

int start = message->GetStartColumn();

152+

int end = message->GetEndColumn();

153153

if (start >= script_start) {

154154

CHECK_GE(end, start);

155155

start -= script_start;