◐ Shell
clean mode source ↗

test: increase spin for eventloop test on s390 · nodejs/node@d6aca0c

nodejs

Commit d6aca0c

mhdawsonmarco-ippolito

authored and

committed

test: increase spin for eventloop test on s390

It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56228 Refs: #41286 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

Lines changed: 0 additions & 4 deletions

Original file line numberDiff line numberDiff line change

@@ -51,7 +51,3 @@ test-tls-securepair-client: PASS, FLAKY

5151

[$arch==arm]

5252

# https://github.com/nodejs/node/issues/49933

5353

test-watch-mode-inspect: SKIP

54-
55-

[$arch==s390x]

56-

# https://github.com/nodejs/node/issues/41286

57-

test-performance-eventloopdelay: PASS, FLAKY

Lines changed: 5 additions & 0 deletions

Original file line numberDiff line numberDiff line change

@@ -3,6 +3,7 @@

33
44

const common = require('../common');

55

const assert = require('assert');

6+

const os = require('os');

67

const {

78

monitorEventLoopDelay

89

} = require('perf_hooks');

@@ -51,9 +52,13 @@ const { sleep } = require('internal/util');

5152

}

5253
5354

{

55+

const s390x = os.arch() === 's390x';

5456

const histogram = monitorEventLoopDelay({ resolution: 1 });

5557

histogram.enable();

5658

let m = 5;

59+

if (s390x) {

60+

m = m * 2;

61+

}

5762

function spinAWhile() {

5863

sleep(1000);

5964

if (--m > 0) {

0 commit comments