◐ Shell
clean mode source ↗

src: clean up experimental flag variables · nodejs/node@dafed45

Original file line numberDiff line numberDiff line change

@@ -269,13 +269,9 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {

269269

isolate->SetModifyCodeGenerationFromStringsCallback(

270270

modify_code_generation_from_strings_callback);

271271
272-

Mutex::ScopedLock lock(node::per_process::cli_options_mutex);

273-

if (per_process::cli_options->get_per_isolate_options()

274-

->get_per_env_options()

275-

->experimental_fetch) {

276-

isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);

277-

}

272+

isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);

278273
274+

Mutex::ScopedLock lock(node::per_process::cli_options_mutex);

279275

if (per_process::cli_options->get_per_isolate_options()

280276

->experimental_shadow_realm) {

281277

isolate->SetHostCreateShadowRealmContextCallback(

Original file line numberDiff line numberDiff line change

@@ -582,7 +582,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {

582582

"experimental node:sqlite module",

583583

&EnvironmentOptions::experimental_sqlite,

584584

kAllowedInEnvvar,

585-

true);

585+

HAVE_SQLITE);

586586

AddOption("--experimental-quic",

587587

#ifndef OPENSSL_NO_QUIC

588588

"experimental QUIC support",

Original file line numberDiff line numberDiff line change

@@ -124,9 +124,8 @@ class EnvironmentOptions : public Options {

124124

bool enable_source_maps = false;

125125

bool experimental_addon_modules = false;

126126

bool experimental_eventsource = false;

127-

bool experimental_fetch = true;

128127

bool experimental_websocket = true;

129-

bool experimental_sqlite = true;

128+

bool experimental_sqlite = HAVE_SQLITE;

130129

bool experimental_webstorage = false;

131130

#ifndef OPENSSL_NO_QUIC

132131

bool experimental_quic = false;

Original file line numberDiff line numberDiff line change

@@ -62,6 +62,7 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));

6262

builtinModules.forEach((mod) => {

6363

// TODO(@jasnell): Remove once node:quic is no longer flagged

6464

if (mod === 'node:quic') return;

65+

if (mod === 'node:sqlite' && !common.hasSQLite) return;

6566

assert.strictEqual(require.resolve.paths(mod), null);

6667

if (!mod.startsWith('node:')) {

6768

assert.strictEqual(require.resolve.paths(`node:${mod}`), null);