◐ Shell
clean mode source ↗

buffer,util: refactor for performance by Trott · Pull Request #12153 · nodejs/node

Trott

@Trott added buffer

Issues and PRs related to the buffer subsystem.

util

Issues and PRs related to the built-in util module.

labels

Apr 1, 2017

@nodejs-github-bot nodejs-github-bot added buffer

Issues and PRs related to the buffer subsystem.

util

Issues and PRs related to the built-in util module.

labels

Apr 1, 2017 
internal/util.js definied toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

joyeecheung

jasnell pushed a commit that referenced this pull request

Apr 4, 2017 
internal/util.js definied toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

PR-URL: #12153
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request

Apr 11, 2017 
internal/util.js definied toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

PR-URL: nodejs#12153
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott mentioned this pull request

Apr 11, 2017

2 tasks

Trott added a commit to Trott/io.js that referenced this pull request

Apr 21, 2017 
internal/util.js definied toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

PR-URL: nodejs#12153
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request

May 1, 2017 
internal/util.js definied toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

PR-URL: #12153
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott mentioned this pull request

May 16, 2017

4 tasks

Trott added a commit to Trott/io.js that referenced this pull request

May 19, 2017 
internal/util.js defined toInteger() and toLength() but they were only
used by buffer.js. Inlining these small functions results in a small but
statistically-significant performance gain.

PR-URL: nodejs#12153
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the buffer-refactor branch

January 13, 2022 22:45