◐ Shell
clean mode source ↗

test: test documented napi_get_value_int32 behaviour by mhdawson · Pull Request #12633 · nodejs/node

nodejs-github-bot

We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

@nodejs-github-bot added node-api

Issues and PRs related to the Node-API.

test

Issues and PRs related to the tests.

labels

Apr 24, 2017

mhdawson added a commit that referenced this pull request

Apr 26, 2017 
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: #12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request

Apr 10, 2018 
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: nodejs#12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 16, 2018 
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

Backport-PR-URL: #19447
PR-URL: #12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>