◐ Shell
clean mode source ↗

build: reduce one level of spawning in node_gyp by refack · Pull Request #12653 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

tools

Issues and PRs related to the tools directory.

labels

Apr 25, 2017

bnoordhuis

bnoordhuis

`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@refack refack deleted the node-gyp-opt branch

May 16, 2017 19:33

@refack refack restored the node-gyp-opt branch

May 16, 2017 21:49

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@refack refack deleted the node-gyp-opt branch

May 19, 2017 19:34

@refack refack restored the node-gyp-opt branch

May 25, 2017 23:10

MylesBorins pushed a commit that referenced this pull request

Jun 23, 2017 
PR-URL: #12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
PR-URL: #12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 14, 2017 
`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: #12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2017 
`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: #12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

This was referenced

Sep 5, 2017