◐ Shell
clean mode source ↗

(v6.x backport) v8: fix build errors with g++ 7 by kasicka · Pull Request #13574 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added v6.x v8 engine

Issues and PRs related to the V8 dependency.

labels

Jun 9, 2017

@kasicka kasicka changed the title Fix gcc 7 build errors v8: Fix gcc 7 build errors

Jun 9, 2017

@gibfahn gibfahn changed the title v8: Fix gcc 7 build errors (v6.x backport) v8: fix build errors with g++ 7

Jun 9, 2017

@mscdex mscdex added the build

Issues and PRs related to build files or the CI.

label

Jun 9, 2017 
This is a local patch because upstream fixed it differently by moving
large chunks of code out of objects.h.  We cannot easily back-port
those changes due to their size and invasiveness.

Fixes: #10388
PR-URL: #12392
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis

gibfahn pushed a commit to gibfahn/node that referenced this pull request

Jun 17, 2017 
This is a local patch because upstream fixed it differently by moving
large chunks of code out of objects.h.  We cannot easily back-port
those changes due to their size and invasiveness.

Fixes: nodejs#10388
PR-URL: nodejs#12392
Backport-PR-URL: nodejs#13574
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn pushed a commit that referenced this pull request

Jun 20, 2017 
This is a local patch because upstream fixed it differently by moving
large chunks of code out of objects.h.  We cannot easily back-port
those changes due to their size and invasiveness.

Fixes: #10388
PR-URL: #12392
Backport-PR-URL: #13574
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

pabigot added a commit to pabigot/meta-nodejs that referenced this pull request

Jul 9, 2017 
Upstream discussion at: nodejs/node#13574

Signed-off-by: Peter A. Bigot <pab@pabigot.com>

pabigot added a commit to pabigot/meta-nodejs that referenced this pull request

Jul 9, 2017

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
This is a local patch because upstream fixed it differently by moving
large chunks of code out of objects.h.  We cannot easily back-port
those changes due to their size and invasiveness.

Fixes: #10388
PR-URL: #12392
Backport-PR-URL: #13574
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

farshadmgc added a commit to farshadmgc/meta-nodejs that referenced this pull request

Dec 13, 2017

@nyh nyh mentioned this pull request

Jan 28, 2018

nyh added a commit to cloudius-systems/osv-apps that referenced this pull request

Jan 28, 2018 
There is a known bug compiling node 6.* on gcc 7:
nodejs/node#13574
This patch picks up a patch for upstream for fixing the compilation.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

zoltan-ongithub pushed a commit to zoltan-ongithub/pxCore that referenced this pull request

Apr 12, 2019