◐ Shell
clean mode source ↗

errors: improve error types by BridgeAR · Pull Request #13857 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added dont-land-on-v4.x errors

Issues and PRs related to JavaScript errors originated in Node.js core.

lib / src

Issues and PRs related to general changes in the lib or src directory.

whatwg-url

Issues and PRs related to the WHATWG URL implementation.

labels

Jun 21, 2017

@mscdex mscdex added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jun 21, 2017

mscdex

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

jasnell

benjamingr

benjamingr

@BridgeAR BridgeAR changed the title errors: improve error types WIP errors: improve error types

Jun 22, 2017

BridgeAR

mhdawson

1) Add missing lazy assert call
2) Remove obsolete error type
3) Name undocumented error type more appropriate
4) Consolidate error type style (rely on util.format
   instead of using a function)
5) Uppercase the first letter from error messages
6) Improve some internal error parameters

refack

tniessen pushed a commit that referenced this pull request

Jun 28, 2017 
PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

tniessen pushed a commit that referenced this pull request

Jun 28, 2017 
1) Add missing lazy assert call
2) Remove obsolete error type
3) Name undocumented error type more appropriate
4) Consolidate error type style (rely on util.format
   instead of using a function)
5) Uppercase the first letter from error messages
6) Improve some internal error parameters

PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

tniessen pushed a commit that referenced this pull request

Jun 28, 2017 
PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

tniessen pushed a commit that referenced this pull request

Jun 28, 2017 
PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

tniessen pushed a commit that referenced this pull request

Jun 28, 2017 
PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell pushed a commit to jasnell/node that referenced this pull request

Aug 17, 2018 
PR-URL: nodejs#13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Sep 6, 2018 
Backport-PR-URL: #22380
PR-URL: #13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>