◐ Shell
clean mode source ↗

repl: handle null thrown by benjamingr · Pull Request #14306 · nodejs/node

@nodejs-github-bot added the repl

Issues and PRs related to the REPL subsystem.

label

Jul 16, 2017

benjamingr

addaleax

TimothyGu

TimothyGu

Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.

PR-URL: nodejs#14306
Fixes: nodejs#12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>

TimothyGu

jasnell

Fishrock123

@benjamingr

benjamingr pushed a commit that referenced this pull request

Jul 19, 2017
Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.

PR-URL: #14306
Fixes: #12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com

addaleax pushed a commit that referenced this pull request

Jul 22, 2017
Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.

PR-URL: #14306
Fixes: #12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com

Fishrock123 pushed a commit that referenced this pull request

Jul 24, 2017
Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.

PR-URL: #14306
Fixes: #12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com