◐ Shell
clean mode source ↗

deps: update V8 to 6.2 by targos · Pull Request #15362 · nodejs/node

@nodejs-github-bot added tools

Issues and PRs related to the tools directory.

v8 engine

Issues and PRs related to the V8 dependency.

labels

Sep 12, 2017

@targos targos added wip

Issues and PRs that are still a work in progress.

and removed tools

Issues and PRs related to the tools directory.

labels

Sep 12, 2017

@MylesBorins MylesBorins added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Sep 12, 2017

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request

Oct 21, 2017
Some of the addons/stringbytes-external-exceed-max tests are known flaky
after the upgrade to V8 6.2.  The most likely reason is the increase of
the maximum string length from 256 to 1024 MB, pushing their execution
times over the time limit.

Fixes: nodejs#16354
Refs: nodejs#15362

MylesBorins pushed a commit that referenced this pull request

Oct 23, 2017
PR-URL: #16219
Refs: #15362
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 6.2.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
With V8 6.2 there is one line less in the promise trace.

PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax pushed a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
Original commit message:

    avoid constructor inheritance due to compilation issues

    Constructor inheritance of a templated constructor is causing compilation issues for node.js:

    https: //github.com/nodejs/node/pull/15362#issue-257007421
    Change-Id: I7d099ff5a1a2fd5b19c11112ddef8fe824e509f7
    Reviewed-on: https://chromium-review.googlesource.com/707008
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48445}

Refs: v8/v8@0f1dfae
PR-URL: nodejs/node#15362
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax added a commit to ayojs/ayo that referenced this pull request

Oct 26, 2017
PR-URL: nodejs/node#16219
Refs: nodejs/node#15362
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>