◐ Shell
clean mode source ↗

http2: Http2Stream server shutdown setting shuttingDown=true after validating options by trivikr · Pull Request #15676 · nodejs/node

nodejs-github-bot

In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

Refs: nodejs#14985
Fixes: nodejs#15666

@nodejs-github-bot added the http2

Issues or PRs related to the http2 subsystem.

label

Sep 29, 2017

BridgeAR

@BridgeAR BridgeAR changed the title src: Http2Stream server shutdown setting shuttingDown=true after validating options http2: Http2Stream server shutdown setting shuttingDown=true after validating options

Oct 2, 2017

BridgeAR pushed a commit that referenced this pull request

Oct 2, 2017 
In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: #15676
Fixes: #15666
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@trivikr trivikr deleted the http2-test-session-shutdown-options branch

October 2, 2017 06:44

MylesBorins pushed a commit that referenced this pull request

Oct 3, 2017 
In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: #15676
Fixes: #15666
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 3, 2017 
In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: #15676
Fixes: #15666
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 4, 2017 
In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: nodejs/node#15676
Fixes: nodejs/node#15666
Refs: nodejs/node#14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Oct 11, 2017 
In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: #15676
Fixes: #15666
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>