◐ Shell
clean mode source ↗

tools: custom eslint autofix for inspector-check.js by shobhitchittora · Pull Request #16646 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the tools

Issues and PRs related to the tools directory.

label

Oct 31, 2017

@shobhitchittora shobhitchittora changed the title eslint autofix for inspector-check tools: eslint autofix for inspector-check

Oct 31, 2017

@shobhitchittora shobhitchittora changed the title tools: eslint autofix for inspector-check tools: eslint autofix for inspector-check.js

Oct 31, 2017

@shobhitchittora shobhitchittora changed the title tools: eslint autofix for inspector-check.js tools: custom eslint autofix for inspector-check.js

Oct 31, 2017

apapirovski

BridgeAR

addaleax

@addaleax addaleax added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Nov 30, 2017

BridgeAR

shobhitchittora

BridgeAR

1. Adds fixer method
2. Extends test
3. Fixes merge issue

Refs: nodejs#16636
1. Removes extra indentation
2. Removes array to track commomModule AST node.
3. Refactored test

Refs: nodejs#16636
Review comments + updates tests to work with fixer

Refs: nodejs#16636

BridgeAR

rules-utils arguments check + spacing in test file

Refs: nodejs#16636

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 17, 2018

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Feb 17, 2018 
1. Adds fixer method
2. Extends test

PR-URL: nodejs#16646
Refs: nodejs#16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
1. Adds fixer method
2. Extends test

PR-URL: #16646
Refs: #16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
1. Adds fixer method
2. Extends test

PR-URL: #16646
Refs: #16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018 
1. Adds fixer method
2. Extends test

PR-URL: #16646
Refs: #16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
1. Adds fixer method
2. Extends test

PR-URL: nodejs#16646
Refs: nodejs#16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 7, 2018 
1. Adds fixer method
2. Extends test

PR-URL: #16646
Refs: #16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Aug 16, 2018 
1. Adds fixer method
2. Extends test

PR-URL: #16646
Refs: #16636
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>