◐ Shell
clean mode source ↗

tls: set ecdhCurve default to 'auto' by Hativ · Pull Request #16853 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the tls

Issues and PRs related to the tls subsystem.

label

Nov 7, 2017

@mscdex mscdex added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Nov 7, 2017

bnoordhuis

bnoordhuis

sam-github

tniessen

tniessen

For best out-of-the-box compatibility there should not be one default `ecdhCurve` for the tls client, OpenSSL should choose them automatically.

I've had a lot of struggle connecting to a server that did not support the default curve. Many third party modules have no support for setting `ecdhCurve`, therefore I think the tls client should support as much curves as possible by default. Using `'auto'` would achieve this.

Refs: #16196
Refs: #1495
Refs: https://wiki.openssl.org/index.php/Manual:SSL_CTX_set1_curves(3)
Refs: #15206

@ghost ghost mentioned this pull request

Nov 13, 2017

sam-github

tniessen pushed a commit that referenced this pull request

Nov 28, 2017 
For best out-of-the-box compatibility there should not be one default
`ecdhCurve` for the tls client, OpenSSL should choose them
automatically.

See https://wiki.openssl.org/index.php/Manual:SSL_CTX_set1_curves(3)

PR-URL: #16853
Refs: #16196
Refs: #1495
Refs: #15206
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@xPaw xPaw mentioned this pull request

Mar 6, 2018