◐ Shell
clean mode source ↗

src: perf_hooks: fix wrong sized delete by ofrobots · Pull Request #16898 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Nov 9, 2017

addaleax

XadillaX

Depending on the allocator, existing code leaks memory.

PR-URL: nodejs#16898
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
Depending on the allocator, existing code leaks memory.

PR-URL: #16898
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

gibfahn pushed a commit that referenced this pull request

Dec 19, 2017 
Depending on the allocator, existing code leaks memory.

PR-URL: #16898
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

gibfahn pushed a commit that referenced this pull request

Dec 20, 2017 
Depending on the allocator, existing code leaks memory.

PR-URL: #16898
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>