◐ Shell
clean mode source ↗

tty, test: refactor exports and add coverage by cjihrig · Pull Request #16959 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the tty

Issues and PRs related to the tty subsystem.

label

Nov 12, 2017

gireeshpunathil

addaleax

This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Dec 11, 2017 
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request

Dec 11, 2017 
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn pushed a commit that referenced this pull request

Dec 13, 2017 
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn pushed a commit that referenced this pull request

Dec 13, 2017 
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn pushed a commit that referenced this pull request

Dec 13, 2017 
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn pushed a commit that referenced this pull request

Dec 13, 2017 
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

This was referenced

Dec 20, 2017