◐ Shell
clean mode source ↗

src: rename async-wrap -> async_wrap by danbev · Pull Request #17022 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Nov 14, 2017

apapirovski

This commit renames async-wrap to async_wrap for consitency with other
c++ source files.
This commit renames base-object to base_object for consitency with other
c++ source files.
This commit renames req-wrap to req_wrap consitency with other
c++ source files.

danbev added a commit that referenced this pull request

Nov 17, 2017 
This commit renames async-wrap to async_wrap for consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

danbev added a commit that referenced this pull request

Nov 17, 2017 
This commit renames base-object to base_object for consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

danbev added a commit that referenced this pull request

Nov 17, 2017 
This commit renames req-wrap to req_wrap consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@danbev danbev deleted the consistent-naming-sources branch

November 17, 2017 12:16

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
This commit renames async-wrap to async_wrap for consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
This commit renames base-object to base_object for consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
This commit renames req-wrap to req_wrap consitency with other
c++ source files.

PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This was referenced

Jan 16, 2018

gibfahn pushed a commit to gibfahn/node that referenced this pull request

Jan 17, 2018 
This commit renames async-wrap to async_wrap for consitency with other
c++ source files.

PR-URL: nodejs#17022
Backport-PR-URL: nodejs#18179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins pushed a commit that referenced this pull request

Jan 19, 2018 
This commit renames async-wrap to async_wrap for consitency with other
c++ source files.

Backport-PR-URL: #18179
PR-URL: #17022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>