◐ Shell
clean mode source ↗

else:no need to use else by Johnsavadkuhi · Pull Request #17057 · nodejs/node

nodejs-github-bot

good  : 
 if (engine._info)
    return { buffer, engine };
else  
   return buffer;

better  : 
 if (engine._info)
    return { buffer, engine };
 return buffer;

@nodejs-github-bot added the zlib

Issues and PRs related to the zlib subsystem.

label

Nov 15, 2017

evanlucas

apapirovski

@joyeecheung joyeecheung added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 21, 2017

jasnell pushed a commit that referenced this pull request

Nov 22, 2017 
PR-URL: #17057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 28, 2017

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
PR-URL: #17057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
PR-URL: #17057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>