◐ Shell
clean mode source ↗

src: use std::unique_ptr in base-object-inl.h by fhinkel · Pull Request #17079 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Nov 16, 2017

TimothyGu

Drive-by fix: delete superflouos nullptr in ptr.reset().

fhinkel added a commit that referenced this pull request

Nov 19, 2017 
Drive-by fix: delete superflouos nullptr in ptr.reset().

PR-URL: #17079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 12, 2017 
Drive-by fix: delete superflouos nullptr in ptr.reset().

PR-URL: #17079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

gibfahn pushed a commit that referenced this pull request

Dec 19, 2017 
Drive-by fix: delete superflouos nullptr in ptr.reset().

PR-URL: #17079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

gibfahn pushed a commit that referenced this pull request

Dec 20, 2017 
Drive-by fix: delete superflouos nullptr in ptr.reset().

PR-URL: #17079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>