◐ Shell
clean mode source ↗

doc: many grammar fixes to http2.md by Trott · Pull Request #17972 · nodejs/node

added 17 commits

January 3, 2018 16:42
_shutdown_ is a noun, but the verb form is _shut down_. "There was a
government shutdown during which the government shut down."
_instance_ was misspelled in the doc. The spelling has been corrected.
Use a dash consistently in _pseudo-header_ (which is also consistent
with RFC 7540). Remove scare-quotes from the term.
Use _is_ rather than _are_ following "each of which".

While "each of which are" might seem equally correct in passing, making
the phrase slightly more explicit makes it clear that _is_ is the
correct choice: "each one of which is".
"have need to" -> "need to"
"a block of...headers are received" -> "a block of...headers is
received". The verb is for the block, not the headers.
"that the listener may used to specify" -> "that the listener may use to
specify"
Fix comma splice. Also clarify if/then construction in previous clause.
"an ServerHttp2Stream" -> "a ServerHttp2Stream"
"applications that supports" -> "applications that support"
Fix comma splice. Also "many modules uses" -> "many modules use".
"allows to support" -> "allows supporting"
"request status, headers and data" -> "request status, headers, and
data"
"acknowledgement" -> "acknowledgment"

@nodejs-github-bot nodejs-github-bot added doc

Issues and PRs related to the documentations.

http2

Issues or PRs related to the http2 subsystem.

labels

Jan 4, 2018

starkwang

maclover7

evanlucas

BridgeAR

@BridgeAR BridgeAR added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Jan 4, 2018

tniessen

jasnell pushed a commit that referenced this pull request

Jan 5, 2018
PR-URL: #17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit to jasnell/node that referenced this pull request

Jan 9, 2018
PR-URL: nodejs#17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

Jan 9, 2018
Backport-PR-URL: #18050
PR-URL: #17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

Jan 10, 2018
Backport-PR-URL: #18050
PR-URL: #17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@TimothyGu TimothyGu removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 13, 2018

kjin pushed a commit to kjin/node that referenced this pull request

May 1, 2018
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins pushed a commit that referenced this pull request

May 2, 2018
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17972
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@Trott Trott deleted the http-copyedit branch

January 13, 2022 22:48