◐ Shell
clean mode source ↗

path: fix path.normalize not correctly normalizing relative paths by starkwang · Pull Request #17974 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the path

Issues and PRs related to the path subsystem.

label

Jan 4, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

Fixes: nodejs#17928

@gibfahn gibfahn added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 7, 2018

joyeecheung

@starkwang

starkwang added a commit that referenced this pull request

Jan 11, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: #17974
Fixes: #17928
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@TimothyGu TimothyGu removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 13, 2018

evanlucas pushed a commit that referenced this pull request

Jan 22, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: #17974
Fixes: #17928
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

evanlucas pushed a commit that referenced this pull request

Jan 30, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: #17974
Fixes: #17928
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 27, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: #17974
Fixes: #17928
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 27, 2018 
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: #17974
Fixes: #17928
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>