◐ Shell
clean mode source ↗

[v9.x] test: refactor test-repl by addaleax · Pull Request #18082 · nodejs/node

nodejs-github-bot

- Switch over to async tracking through promises/async fns
- Remove an unused temp dir refresh
- Inline the multiline/npm text prompts into expectations
- Unify handling prompts/stripping prompts out
- Make sure no unexpected data is received by requireing
  all *lines* to be matched, rather than chunks received from
  the REPL. This made the test too loose in terms of
  matched lines and too strict in terms of stream chunking
  requirements.
- Some general cleanup

PR-URL: nodejs#17926

@nodejs-github-bot added test

Issues and PRs related to the tests.

v9.x labels

Jan 10, 2018

evanlucas

evanlucas pushed a commit that referenced this pull request

Jan 15, 2018 
- Switch over to async tracking through promises/async fns
- Remove an unused temp dir refresh
- Inline the multiline/npm text prompts into expectations
- Unify handling prompts/stripping prompts out
- Make sure no unexpected data is received by requireing
  all *lines* to be matched, rather than chunks received from
  the REPL. This made the test too loose in terms of
  matched lines and too strict in terms of stream chunking
  requirements.
- Some general cleanup

Backport-PR-URL: #18082
PR-URL: #17926
Reviewed-By: Evan Lucas <evanlucas@me.com>