doc: un-mark Socket#write “removal” as notable change by addaleax · Pull Request #18083 · nodejs/node

addaleax

Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

addaleax deleted the cl-9-socket-proto-write branch

January 10, 2018 16:22

addaleax added a commit that referenced this pull request

Jan 10, 2018

Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

PR-URL: #18083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit that referenced this pull request

Jan 10, 2018

Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

PR-URL: #18083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to addaleax/nodejs.org that referenced this pull request

Jan 10, 2018

Applied from nodejs/node#18083

---

    doc: un-mark Socket#write “removal” as notable change

    Since the method is inherited from `Writable`, usage of the method
    does not change at all after its removal as an explicit method.

    Calling it out as notable might therefore be more confusing than
    helpful.

addaleax added a commit to nodejs/nodejs.org that referenced this pull request

Jan 10, 2018

Applied from nodejs/node#18083

---

    doc: un-mark Socket#write “removal” as notable change

    Since the method is inherited from `Writable`, usage of the method
    does not change at all after its removal as an explicit method.

    Calling it out as notable might therefore be more confusing than
    helpful.