◐ Shell
clean mode source ↗

test: change assert message to default by ryanmahan · Pull Request #18259 · nodejs/node

nodejs-github-bot

assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

Refs: nodejs#13296

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jan 19, 2018 
Condensed line 14 assert to one line

Leko

Leko approved these changes Jan 20, 2018

maclover7

@maclover7 maclover7 added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 20, 2018

BridgeAR

Trott pushed a commit to Trott/io.js that referenced this pull request

Jan 23, 2018 
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: nodejs#18259
Refs: nodejs#13296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request

Jan 30, 2018 
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: #18259
Refs: #13296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 27, 2018 
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: #18259
Refs: #13296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 27, 2018 
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: #18259
Refs: #13296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Feb 27, 2018

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: nodejs#18259
Refs: nodejs#13296
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>