◐ Shell
clean mode source ↗

test: actually test tty getColorDepth() by Fishrock123 · Pull Request #18800 · nodejs/node

@Fishrock123 added test

Issues and PRs related to the tests.

tty

Issues and PRs related to the tty subsystem.

labels

Feb 15, 2018

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 15, 2018

Trott

Trott

addaleax

BridgeAR

@BridgeAR BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 18, 2018
This utility is fairly generic and likely useful for more than one test.

PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
TTY tests should almost never be placed in `/parallel/`. Skipping TTY
tests there due to missing tty fds just means they will never be run,
ever, on any system.

This moves the tty-get-color-depth test to `/pseudo-tty/` where the test
runner will actually make a pty fd.

Refs: nodejs#17615
PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Fishrock123 added a commit to Fishrock123/node that referenced this pull request

Feb 22, 2018
Follow-up from nodejs#18800

Code that tries to exercise tty fds must be placed in `/pseudo-tty/`.

PR-URL: nodejs#18886
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Fishrock123 added a commit that referenced this pull request

Feb 22, 2018
Follow-up from #18800

Code that tries to exercise tty fds must be placed in `/pseudo-tty/`.

PR-URL: #18886
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 1, 2018
This utility is fairly generic and likely useful for more than one test.

PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 1, 2018
TTY tests should almost never be placed in `/parallel/`. Skipping TTY
tests there due to missing tty fds just means they will never be run,
ever, on any system.

This moves the tty-get-color-depth test to `/pseudo-tty/` where the test
runner will actually make a pty fd.

Refs: nodejs#17615
PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 1, 2018
Follow-up from nodejs#18800

Code that tries to exercise tty fds must be placed in `/pseudo-tty/`.

PR-URL: nodejs#18886
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
This utility is fairly generic and likely useful for more than one test.

PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
TTY tests should almost never be placed in `/parallel/`. Skipping TTY
tests there due to missing tty fds just means they will never be run,
ever, on any system.

This moves the tty-get-color-depth test to `/pseudo-tty/` where the test
runner will actually make a pty fd.

Refs: nodejs#17615
PR-URL: nodejs#18800
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
Follow-up from nodejs#18800

Code that tries to exercise tty fds must be placed in `/pseudo-tty/`.

PR-URL: nodejs#18886
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>