◐ Shell
clean mode source ↗

http: remove default 'drain' listener on upgrade by lpinca · Pull Request #18866 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the http

Issues or PRs related to the http subsystem.

label

Feb 19, 2018

addaleax

Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

BridgeAR

@BridgeAR BridgeAR added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Feb 20, 2018

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Feb 22, 2018 
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

PR-URL: nodejs#18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@lpinca lpinca deleted the remove/drain-listener branch

February 22, 2018 16:19

addaleax pushed a commit to addaleax/node that referenced this pull request

Feb 26, 2018 
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

PR-URL: nodejs#18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax pushed a commit that referenced this pull request

Feb 26, 2018 
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

PR-URL: #18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Apr 13, 2018 
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

PR-URL: #18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.

PR-URL: nodejs#18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>