◐ Shell
clean mode source ↗

src: remove node namespace qualifiers by danbev · Pull Request #18962 · nodejs/node

nodejs-github-bot

This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Feb 23, 2018

addaleax

TimothyGu

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 23, 2018

Fishrock123

danbev added a commit that referenced this pull request

Feb 26, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@danbev danbev deleted the remove-node-namespace-qualifier branch

February 26, 2018 06:26

addaleax pushed a commit to addaleax/node that referenced this pull request

Feb 26, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: nodejs#18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

addaleax pushed a commit that referenced this pull request

Feb 26, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: nodejs#18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 8, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 9, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2018 
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>