◐ Shell
clean mode source ↗

test: fix test-abort-backtrace in shared lib build by yhwang · Pull Request #19213 · nodejs/node

nodejs-github-bot

When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: nodejs#18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 7, 2018

richardlau

@yhwang yhwang added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 7, 2018

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 11, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: nodejs#18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#19213
Refs: nodejs#18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@yhwang yhwang deleted the sharedlib-test-abort-backtrace branch

March 12, 2018 16:35

targos pushed a commit that referenced this pull request

Mar 17, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: #18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #19213
Refs: #18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 20, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: #18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #19213
Refs: #18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: nodejs#18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#19213
Refs: nodejs#18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit to jasnell/node that referenced this pull request

Aug 17, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: nodejs#18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#19213
Refs: nodejs#18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 6, 2018 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: #18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

Backport-PR-URL: #22380
PR-URL: #19213
Refs: #18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>