module: force require('process') to return a reference to process by lxe · Pull Request #206 · nodejs/node
Conversation
This makes require('process') always return a reference to the global process object. Fixes #157
Why not module.exports = global.process?
@vkurchatkin there were a few ways to do this... making lib/process.js with module.exports = process is certainly one of them, and I wasn't sure which one would look more like a hack. We're already removing lib/sys which did the one-line re-export, so I was thinking we probably shouldn't create whole files just to do a re-export.
I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js.
@bnoordhuis added lib/process.js instead of the conditionals.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to either // Copyright io.js contributors or your own / your company's name?
LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that.
@lxe Still one nit but if you fix that, I'll land it. Thanks.
This makes require('process') always return a reference to the global
process object.
bnoordhuis pushed a commit that referenced this pull request
This makes require('process') always return a reference to the global
process object.
PR-URL: #206
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks!
ftr, agreed to merge this in TC meeting 2014-12-30 #229
This was referenced
