◐ Shell
clean mode source ↗

test,benchmark: have benchmark tests confirm that only one line of output is generated per benchmark file by Trott · Pull Request #21046 · nodejs/node

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

May 30, 2018

@Trott Trott added wip

Issues and PRs that are still a work in progress.

test

Issues and PRs related to the tests.

benchmark

Issues and PRs related to the benchmark subsystem.

labels

May 30, 2018

apapirovski

addaleax

@Trott Trott added blocked

PRs that are blocked by other issues or PRs.

and removed wip

Issues and PRs that are still a work in progress.

labels

Jun 1, 2018
Prevent misc benchmark files from running more than one benchmark
during tests.
Move C++ benchmark useful for NAPI to its own directory. This will
isolate the benchmark so it can be excluded from testing that applies to
all other benchmarks but not this one.
Check that benchmark tests are not running longer than necessary by
confirming that they only produce one set of configs to report on per
benchmark file.

@Trott Trott removed the blocked

PRs that are blocked by other issues or PRs.

label

Jun 15, 2018

addaleax

Trott added a commit to Trott/io.js that referenced this pull request

Jun 19, 2018
Prevent misc benchmark files from running more than one benchmark
during tests.

PR-URL: nodejs#21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott added a commit to Trott/io.js that referenced this pull request

Jun 19, 2018
Move C++ benchmark useful for NAPI to its own directory. This will
isolate the benchmark so it can be excluded from testing that applies to
all other benchmarks but not this one.

PR-URL: nodejs#21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott added a commit to Trott/io.js that referenced this pull request

Jun 19, 2018
Check that benchmark tests are not running longer than necessary by
confirming that they only produce one set of configs to report on per
benchmark file.

PR-URL: nodejs#21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Jun 20, 2018
Prevent misc benchmark files from running more than one benchmark
during tests.

PR-URL: #21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Jun 20, 2018
Move C++ benchmark useful for NAPI to its own directory. This will
isolate the benchmark so it can be excluded from testing that applies to
all other benchmarks but not this one.

PR-URL: #21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Jun 20, 2018
Check that benchmark tests are not running longer than necessary by
confirming that they only produce one set of configs to report on per
benchmark file.

PR-URL: #21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>