◐ Shell
clean mode source ↗

build: fix cctest build failure in Windows by yhwang · Pull Request #21228 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

Jun 9, 2018

refack

@yhwang yhwang added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 18, 2018

bnoordhuis

@apapirovski apapirovski removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 25, 2018 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

@yhwang yhwang added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 13, 2018

addaleax pushed a commit that referenced this pull request

Sep 17, 2018 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>

targos pushed a commit that referenced this pull request

Sep 18, 2018 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>

targos pushed a commit that referenced this pull request

Sep 19, 2018 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>

targos pushed a commit that referenced this pull request

Sep 20, 2018 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>

@yhwang yhwang deleted the fix-windows-undefined-symbols branch

November 30, 2018 19:00

BethGriggs pushed a commit to BethGriggs/node that referenced this pull request

Mar 20, 2019 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#21228
Reviewed-By: Refael Ackermann <refack@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 20, 2019 
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

Backport-PR-URL: #25758
PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>