◐ Shell
clean mode source ↗

tests,aix: avoid running fsync on directory by jBarz · Pull Request #21298 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jun 13, 2018 
The underlying fsync system call returns EBADF on a file descriptor
for an open directory. So avoid running fsync on it.

richardlau

@trivikr trivikr added the aix

Issues and PRs related to the AIX platform.

label

Jun 13, 2018

gireeshpunathil

richardlau

mhdawson

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 14, 2018

cjihrig pushed a commit to libuv/libuv that referenced this pull request

Jun 19, 2018 
Unlike other platforms, the fsync call on aix will not accept
non-regular file file-descriptors.

Refs: nodejs/node#21298
PR-URL: #1879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

richardlau pushed a commit that referenced this pull request

Jun 22, 2018 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Jun 24, 2018 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 21, 2019 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>