test: move net bytes-per-chunk test to parallel by addaleax · Pull Request #21322 · nodejs/node
This was added in 3217e8e as a regression test for a security patch. We moved it to `sequential` to lower the risk of creating a flaky test, because an earlier version of it was failing one some platforms. There is no known reason why te test should be flaky in this form, though, and moving it to parallel would be good because it does take around 3 seconds that would otherwise fully count towards the test run time.
addaleax
added
the
author ready
label
addaleax
deleted the
move-net-bytes-per-incoming-chunk
branch
addaleax added a commit that referenced this pull request
This was added in 3217e8e as a regression test for a security patch. We moved it to `sequential` to lower the risk of creating a flaky test, because an earlier version of it was failing one some platforms. There is no known reason why te test should be flaky in this form, though, and moving it to parallel would be good because it does take around 3 seconds that would otherwise fully count towards the test run time. PR-URL: #21322 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: nodejs#21322 (comment)
Trott
mentioned this pull request
2 tasks
targos pushed a commit that referenced this pull request
This was added in 3217e8e as a regression test for a security patch. We moved it to `sequential` to lower the risk of creating a flaky test, because an earlier version of it was failing one some platforms. There is no known reason why te test should be flaky in this form, though, and moving it to parallel would be good because it does take around 3 seconds that would otherwise fully count towards the test run time. PR-URL: #21322 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: #21322 (comment) PR-URL: #21457 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: #21322 (comment) PR-URL: #21457 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters